Code review comment for lp:~jseutter/testresources/py3_without_distribute

Revision history for this message
Barry Warsaw (barry) wrote :

This looks pretty good to me. Unfortunately the test suite has a hidden dependency on fixtures, so that needs to get ported too. :(

% python test_all.py
Traceback (most recent call last):
  File "test_all.py", line 127, in <module>
    sys.exit(main(sys.argv))
  File "test_all.py", line 119, in main
    test_suite().visit(visitor)
  File "test_all.py", line 82, in test_suite
    result.addTest(testresources.test_suite())
  File "/tmp/tr/lib/python3.2/site-packages/testresources-0.2.5-py3.2.egg/testresources/__init__.py", line 29, in test_suite
    return testresources.tests.test_suite()
  File "/tmp/tr/lib/python3.2/site-packages/testresources-0.2.5-py3.2.egg/testresources/tests/__init__.py", line 27, in test_suite
    import testresources.tests.test_test_resource
  File "/tmp/tr/lib/python3.2/site-packages/testresources-0.2.5-py3.2.egg/testresources/tests/test_test_resource.py", line 18, in <module>
    from fixtures.tests.helpers import LoggingFixture
ImportError: No module named fixtures.tests.helpers

review: Approve

« Back to merge proposal