Launchpad itself

Code review comment for lp:~jtv/launchpad/bug-409330

  1. bug-409330
  2. Merge into devel
Revision history for this message
Celso Providelo (cprov) wrote :

Jeroen,

Thanks for investigating and find a quick solution for this production bug.

You need a new test for VerifyPOFileStats, to certify 'start_id' is handled as you expect. Other than that the code changes are good and harmless.

I'm assuming you are coordinating these changes with LOSAs, so they can add the new cronjob with the right parameters in production once it's CPed.

review: Approve

« Back to merge proposal