Code review comment for lp:~jtv/launchpad/bug-488218

Thanks for the review!

> r=me, but two thoughts. The first is general - is there not a better way to
> handle
> these translation credits so that they're not translatable messages
> at all? I guess not, otherwise you would have done it.

Right. It's actually an elegant solution in the problem domain that these are in all respects translatable messages. Another way of looking at it is that we, as an implementation, just happen to automate their translation.

> Second thought: you said in your cover letter that "translations are made
> by persons, not teams", but translations are still displayed for other
> teams - just not the rosetta experts, is that right?
> (eg. http://pastebin.ubuntu.com/328399/), if so, why? (just for my
> understanding)

Yes. One of the tests also showed translations made by another team, though I don't know how it was supposed to arrive at a situation where those can exist. One way I could think of, though, is by changing a person into a team. I believe that's possible, though I haven't checked.

Functionally, there's nothing wrong with crediting team contributions if they should exist. It's really just in the case of rosetta_experts that listing the team as a contributor becomes totally meaningless.

Jeroen