Code review comment for lp:~jtv/launchpad/bug-489068

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

= Bug 489068 =

Testfix branch.

My test for the EC2 breakage (bug 488695) is breaking because credentials.py imports boto, which apparently isnt' available in our test environment.

Luckily, the import from credentials.py is only needed in the one factory method that my test doesn't use. So as I did with get_lp_login, I can move the import into that factory. That way the test skips them.

{{{
./bin/test -vv -t ec2instance
}}}

Jeroen

« Back to merge proposal