One minor comment:
19 === modified file 'lib/lp/translations/tests/test_translationtemplatesbuildbehavior.py' 20 --- lib/lp/translations/tests/test_translationtemplatesbuildbehavior.py 2010-03-06 04:57:40 +0000 21 +++ lib/lp/translations/tests/test_translationtemplatesbuildbehavior.py 2010-03-10 18:05:30 +0000 38 @@ -81,7 +83,12 @@ 39 class TestTranslationTemplatesBuildBehavior(TestCaseWithFactory): 40 """Test `TranslationTemplatesBuildBehavior`.""" 41 42 - layer = ZopelessDatabaseLayer 43 + layer = LaunchpadZopelessLayer 44 + 45 + def _becomeBuilddMaster(self): 46 + """Log into the database as the buildd master.""" 47 + transaction.commit() ^^^ Is the transaction.commit() really necessary here, would a Store.flush not work ?
48 + self.layer.switchDbUser(config.builddmaster.dbuser) 49 50 def _makeBehavior(self): 51 """Create a TranslationTemplatesBuildBehavior.
« Back to merge proposal
One minor comment:
19 === modified file 'lib/lp/ translations/ tests/test_ translationtemp latesbuildbehav ior.py' translations/ tests/test_ translationtemp latesbuildbehav ior.py 2010-03-06 04:57:40 +0000 translations/ tests/test_ translationtemp latesbuildbehav ior.py 2010-03-10 18:05:30 +0000 TemplatesBuildB ehavior( TestCaseWithFac tory): platesBuildBeha vior`." "" eLayer ssLayer ster(self) : commit( ) commit( ) really necessary here, would a Store.flush not work ?
20 --- lib/lp/
21 +++ lib/lp/
38 @@ -81,7 +83,12 @@
39 class TestTranslation
40 """Test `TranslationTem
41
42 - layer = ZopelessDatabas
43 + layer = LaunchpadZopele
44 +
45 + def _becomeBuilddMa
46 + """Log into the database as the buildd master."""
47 + transaction.
^^^ Is the transaction.
48 + self.layer. switchDbUser( config. builddmaster. dbuser) self): latesBuildBehav ior.
49
50 def _makeBehavior(
51 """Create a TranslationTemp