Code review comment for lp:~jtv/launchpad/bug-536769

Revision history for this message
Michael Nelson (michael.nelson) wrote :

I've got nothing to add to Jelmer's review.

I did have one question for my own learning though: is this the type of thing you were *against* using the with statement for? ie. creating a context manager that also switched back so that you could do:

with dbUserAs(config.builddmaster.dbuser):
    ...

?

@jelmer: I remembered after our conversation, the review type should be code*. Thanks for the review! I nice easy one to start with :-)

review: Approve (code)

« Back to merge proposal