> For the TestGetBzrCommitterID test case, remove the tearDown, and instead
> do something like:
>
> committer = DirectBranchCommit(...)
> self.addCleanup(committer.unlock)
Great! Done.
> The test should also work in the DatabaseFunctionalLayer rather than the
> ZopelessDatabaseLayer. Unless there is a reason why you are running it in
> that layer, in which case, document it.
Changed the layer.
> How about "Launchpad Translations on behalf of %s"?
I was hesitant to put it like that because it's longer, but agree it's better. Done.
> For the TestGetBzrCommi tterID test case, remove the tearDown, and instead mit(... ) (committer. unlock)
> do something like:
>
> committer = DirectBranchCom
> self.addCleanup
Great! Done.
> The test should also work in the DatabaseFunctio nalLayer rather than the eLayer. Unless there is a reason why you are running it in
> ZopelessDatabas
> that layer, in which case, document it.
Changed the layer.
> How about "Launchpad Translations on behalf of %s"?
I was hesitant to put it like that because it's longer, but agree it's better. Done.