Code review comment for lp:~jtv/launchpad/db-bug-499404

Revision history for this message
Jonathan Lange (jml) wrote :

The database patch looks good, but it leaves me wondering, where do the results of the job go?

On the code side, the interface that you have there looks an awful lot like IBranchJob -- should it subclass from it? A lot of the branch jobs use IFooJobSource, rather than IFooJobSet. Perhaps it's worth considering using similar names.

jml

review: Needs Information (db)

« Back to merge proposal