Code review comment for lp:~jtv/launchpad/message-sharing-rearrange-commits

= Rearranging gc and commits in message-sharing migration =

Memory usage is still an issue in the message-sharing migration script. It commits and gc's periodically, but in phase 3 we still see increasing object counts.

This script is a minor tweak to give us better debug output: it makes the explicit garbage-collection runs happen just after a commit, when there's an absolute minimum number of objects still pinned in memory by the ongoing transaction.

There's no functional impact, but the change makes sense even outside the debugging context because it's... well, it's... uh, it's just better.

No lint, no tests (well, run {{{bin/test -vv -t message.sharing}}} if you feel like it) and no miracle cures for this one.

Jeroen