Merge lp:~jtv/launchpad/recife-limited-setcurrenttranslation into lp:~launchpad/launchpad/recife

Hi Jeroen,
thanks for doing this and putting up with Danilo's mess... ;-) You (two)
really achieved good test coverage it seems. I have to admit I did not trace
every test, though, to see if the coverage is complete. I trust you there.

But I *did* run the tests and they passed. Good job! ;-)

Since I could not find any real problems I had to resort to complaining about
minor stuff like long method names. Also, I think I see SQLObject code introduced.

Let me heare what you think about my comments and let's do another round.

Cheers,
Hennning

> === added file 'lib/lp/translations/tests/helpers.py'
> --- lib/lp/translations/tests/helpers.py 1970-01-01 00:00:00 +0000
> +++ lib/lp/translations/tests/helpers.py 2010-06-29 10:50:45 +0000
> @@ -0,0 +1,146 @@
> +# Copyright 2010 Canonical Ltd. This software is licensed under the
> +# GNU Affero General Public License version 3 (see the file LICENSE).
> +
> +__all__ = [
> + 'get_all_important_translations',
> + 'make_translationmessage',
> + 'make_translationmessage_for_context',
> + ]
> +
> +from zope.security.proxy import removeSecurityProxy
> +
> +from canonical.database.sqlbase import sqlvalues
> +
> +from lp.translations.interfaces.translationmessage import (
> + RosettaTranslationOrigin,
> + TranslationValidationStatus)
> +from lp.translations.model.translationmessage import (
> + TranslationMessage)
> +
> +def make_translationmessage_for_context(factory, pofile, potmsgset=None,
> + current=True, other=False,
> + diverged=False, translations=None):
> + """A low-level way of constructing TMs appropriate to `pofile` context."""
> + assert pofile is not None, "You must pass in an existing POFile."
> +
> + potemplate = pofile.potemplate
> + if potemplate.distroseries is not None:
> + ubuntu = current
> + upstream = other
> + else:
> + ubuntu = other
> + upstream = current
> + return make_translationmessage(
> + factory, pofile, potmsgset, ubuntu, upstream, diverged, translations)
> +
> +def make_translationmessage(factory, pofile=None, potmsgset=None,
> + ubuntu=True, upstream=True,
> + diverged=False, translations=None):
> + """Creates a TranslationMessage directly and sets relevant parameters.
> +
> + This is very low level function used to test core Rosetta
> + functionality such as setCurrentTranslation() method. If not used
> + correctly, it will trigger unique constraints.
> + """
> + if pofile is None:
> + pofile = factory.makePOFile('sr')
> + if potmsgset is None:
> + potmsgset = factory.makePOTMsgSet(
> + potemplate=pofile.potemplate)
> + if translations is None:
> + translations = [factory.getUniqueString()]
> + if diverged:
> + potemplate = pofile.potemplate
> + else:
> + potemplate = None
> +
> + # Parameters we don't care about are origin, submitter and
> + # validation_status.
> + origin = RosettaTranslationOrigin.SCM
> + submitter = pofile.owner
> + validation_status = TranslationValidat...

Hi Henning,

Thanks for a thorough review. A lot of stuff needs polishing here, and in fact some of this polish I had lost in the shenanigans I went through trying to get the branches to fit together. So a good thing you spotted them.

> > === added file 'lib/lp/translations/tests/helpers.py'
> > --- lib/lp/translations/tests/helpers.py 1970-01-01 00:00:00 +0000
> > +++ lib/lp/translations/tests/helpers.py 2010-06-29 10:50:45 +0000
> > @@ -0,0 +1,146 @@
> > +# Copyright 2010 Canonical Ltd. This software is licensed under the
> > +# GNU Affero General Public License version 3 (see the file LICENSE).
> > +
> > +__all__ = [
> > + 'get_all_important_translations',
> > + 'make_translationmessage',
> > + 'make_translationmessage_for_context',
> > + ]
> > +
> > +from zope.security.proxy import removeSecurityProxy
> > +
> > +from canonical.database.sqlbase import sqlvalues
> > +
> > +from lp.translations.interfaces.translationmessage import (
> > + RosettaTranslationOrigin,
> > + TranslationValidationStatus)
> > +from lp.translations.model.translationmessage import (
> > + TranslationMessage)
> > +
> > +def make_translationmessage_for_context(factory, pofile, potmsgset=None,

Oops, that should have been a double blank line of course. That mistake is in other places as well.

> > + current=True, other=False,
> > + diverged=False, translations=None):
> > + """A low-level way of constructing TMs appropriate to `pofile`
> context."""
> > + assert pofile is not None, "You must pass in an existing POFile."
> > +
> > + potemplate = pofile.potemplate
> > + if potemplate.distroseries is not None:
> > + ubuntu = current
> > + upstream = other
> > + else:
> > + ubuntu = other
> > + upstream = current
> > + return make_translationmessage(
> > + factory, pofile, potmsgset, ubuntu, upstream, diverged,
> translations)
> > +
> > +def make_translationmessage(factory, pofile=None, potmsgset=None,
> > + ubuntu=True, upstream=True,
> > + diverged=False, translations=None):
> > + """Creates a TranslationMessage directly and sets relevant parameters.
> > +
> > + This is very low level function used to test core Rosetta
> > + functionality such as setCurrentTranslation() method. If not used
> > + correctly, it will trigger unique constraints.
> > + """
> > + if pofile is None:
> > + pofile = factory.makePOFile('sr')
> > + if potmsgset is None:
> > + potmsgset = factory.makePOTMsgSet(
> > + potemplate=pofile.potemplate)
> > + if translations is None:
> > + translations = [factory.getUniqueString()]
> > + if diverged:
> > + potemplate = pofile.potemplate
> > + else:
> > + potemplate = None
> > +
> > + # Parameters we don't care about are origin, submitter and
> > + # validation_status.
> > + origin = RosettaTranslationOrigin.SCM
> > + submitter = pofile.owner
> > + validation_status = TranslationValidationStatus.UNKNOWN
> > +
> > + translations = dict(
> > + ...

Thank you for your cooperation. ;-)