Code review comment for lp:~jtv/lazr-js/bug-480986
Revision history for this message
| Jeroen T. Vermeulen (jtv) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
= Bug 480986 =
The Picker's escape handling wasn't working in Chrome. The reason is this Chrome issue: http://
In a nutshell, Chrome doesn't do keypress events for the escape key. This was not affecting the autocomplete widget or the inline editor since they listen for "key" events (and obey the escape right when you press it rather than when you release it). But it did affect the other overlay-based widgets since it was in the overlay that the escape key was handled. To reproduce, open any of these widgets (choiceedit, formoverlay, overlay, or picker) in Chrome or Chromium and press escape. It should close the widget, but with the bug still present it will do nothing.
In this branch, the overlay's escape handling is replaced with the inline editor's approach. I discussed with the author of the original escape handling in the overlay and we found that this was the best approach after all.
You'll also find a few drive-by cleanups prompted by "make lint."
Jeroen