© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
a60fb26
(Get the code!)
As discussed on IRC yesterday, I think r10734 is a step backwards. You could achieve the same result by leaving the errback as it was and adding a callback that swallows the result and returns None. This would leave fewer code branches in the error path, which means that we can spend less time messing about on dogfood when something else unexpected happens.
That said, the branch as it stands contains no regressions compared to *trunk*, and is definitely a net improvement, so I'm happy for you to land it as-is.