The new code looks good. You should add an explanation about why you don't disable builders as soon as they've got a failure, i.e. why the threshold exists at all.
Also, in my previous review just prior to commit r11699, I suggested adding several XXXs. Could you please do that.
The new code looks good. You should add an explanation about why you don't disable builders as soon as they've got a failure, i.e. why the threshold exists at all.
Also, in my previous review just prior to commit r11699, I suggested adding several XXXs. Could you please do that.
Do both of these things, and then land.