Merge lp:~julian-edwards/launchpad/oops-dspr-page-bug-592417 into lp:launchpad
| Status: | Merged |
|---|---|
| Merged at revision: | 11095 |
| Proposed branch: | lp:~julian-edwards/launchpad/oops-dspr-page-bug-592417 |
| Merge into: | lp:launchpad |
| Diff against target: | 0 lines |
| To merge this branch: | bzr merge lp:~julian-edwards/launchpad/oops-dspr-page-bug-592417 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Gary Poster (community) | cp | Approve | |
| Michael Nelson (community) | ui | Approve | |
| Graham Binns (community) | code | Approve | |
|
Review via email:
|
|||
Commit message
Prevent the distroseriessou
Description of the change
= Summary =
Fix https:/
The page is blowing up when trying to render file details for deleted files.
== Proposed fix ==
The template should render an unlinked filename with no details if the file
was deleted.
== Pre-implementation notes ==
Basically the same implementation as
https:/
cache/+merge/26329
as discussed with noodles.
== Implementation details ==
Simple fix to the template to detect if the file was deleted or not, and
renders:
filename (deleted)
instead of the linked files with size/md5 etc.
== Tests ==
bin/test -cvv test_distrosour
== Demo and Q/A ==
Already on dogfood and working fine. See:
https:/
| Graham Binns (gmb) | # |
| Julian Edwards (julian-edwards) wrote | # |
| Gary Poster (gary) | # |
Thanks Julian. A small UI improvement that I'll leave up to you:
AFAICS, the other page that was fixed didn't include the size and checksum columns, so when I look at the example page, it almost seems as if the deleted file isn't part of the table.
A really easy fix is to change the class for that table from "summary" (which does nothing afaics) to "listing" - and see what you think (in case you haven't seen it, you can do it directly in the Chromium inspector to try it out)
Another option would be to add "N/A" or whatever we use as the standard for not applicable for the size/md5 for deleted files, but I don't think this is necessary when the "listing" class is used.