Code review comment for lp:~julian-edwards/launchpad/oops-dspr-page-bug-592417

Revision history for this message
Michael Nelson (michael.nelson) wrote :

Thanks Julian. A small UI improvement that I'll leave up to you:

AFAICS, the other page that was fixed didn't include the size and checksum columns, so when I look at the example page, it almost seems as if the deleted file isn't part of the table.

A really easy fix is to change the class for that table from "summary" (which does nothing afaics) to "listing" - and see what you think (in case you haven't seen it, you can do it directly in the Chromium inspector to try it out)

Another option would be to add "N/A" or whatever we use as the standard for not applicable for the size/md5 for deleted files, but I don't think this is necessary when the "listing" class is used.

review: Approve (ui)

« Back to merge proposal