Launchpad itself

Code review comment for lp:~julian-edwards/launchpad/slow-ppa-search-bug-659129

Revision history for this message

Julian Edwards (julian-edwards) wrote on 2010-10-14:

Since it's not updating the diff with the new changes, here it is:

1	=== modified file 'lib/lp/registry/model/distribution.py'
2	--- lib/lp/registry/model/distribution.py 2010-10-13 09:17:14 +0000
3	+++ lib/lp/registry/model/distribution.py 2010-10-14 10:16:50 +0000
4	@@ -1442,12 +1442,11 @@
5	clauses = ["""
6	Archive.purpose = %s AND
7	Archive.distribution = %s AND
8	- Person.id = Archive.owner AND
9	- Person.id = ValidPersonOrTeamCache.id
10	+ Archive.owner = ValidPersonOrTeamCache.id
11	""" % sqlvalues(ArchivePurpose.PPA, self)]
12
13	- clauseTables = ['Person', 'ValidPersonOrTeamCache']
14	- orderBy = ['Person.name']
15	+ clauseTables = ['ValidPersonOrTeamCache']
16	+ orderBy = ['Archive.displayname']
17
18	if not show_inactive:
19	active_statuses = (PackagePublishingStatus.PUBLISHED,
20
21	=== modified file 'lib/lp/soyuz/stories/ppa/xx-private-ppas.txt'
22	--- lib/lp/soyuz/stories/ppa/xx-private-ppas.txt 2010-02-24 15:59:22 +0000
23	+++ lib/lp/soyuz/stories/ppa/xx-private-ppas.txt 2010-10-14 10:28:00 +0000
24	@@ -49,10 +49,10 @@
25	>>> cprov_browser.getControl(name="show_inactive").value = True
26	>>> cprov_browser.getControl('Search', index=0).click()
27	>>> list_ppas_in_browser_page(cprov_browser)
28	+ PPA for Celso Providelo...
29	+ PPA for Mark Shuttleworth...
30	+ PPA for No Privileges Person...
31	PPA named p3a for Celso Providelo...
32	- PPA for Celso Providelo...
33	- PPA for Mark Shuttleworth...
34	- PPA for No Privileges Person...
35
36	Let's make a new team PPA for "landscape-developers" and make it
37	private.