Code review comment for lp:~justin-fathomdb/nova/check-subprocess-exit-code

looks good. I requested a review from Termie, since he wrote the process.py code. Also, i noticed a few problems with nova-volume's use of simple_execute. I had to add an error_ok or two because some of the shell calls were returning output on stderr. We might need to run through creating a few volumes with my branch lp:~vishvananda/nova/fix-volumes and see if we need check_error_code=False on any of the commands. I only noticed this stuff when actually creating volumes (i.e. not using fakes).