Code review comment for lp:~justin-fathomdb/nova/check-subprocess-exit-code

Revision history for this message
justinsb (justin-fathomdb) wrote :

Yes - it definitely needs an Twisted expert's eye on it. I certainly haven't run through every code path, so odds are the error checking will surface more issues and break things, but I think that at this stage of the project that's probably the right thing to do - we at least want to know when things are failing! I found some problems with the virtualenv stuff, for example, which otherwise were going unnoticed, and probably resulting in mixed versions of python libs etc...

« Back to merge proposal