Code review comment for lp:~justin-fathomdb/nova/check-subprocess-exit-code

Revision history for this message
termie (termie) wrote :

weird, I got Eric's message but not the message from Justin. Sorry for the late reply, I expected to get an email about it.

Justin: That is a NOTE not a TODO, I don't see any use cases where this behavior is a problem, what I am asking you for is a use case that we have right now where we can't do what we want because of this behavior. I think the change you are proposing increases the complexity of the code significantly and would rather it not happen unless there is a good reason for it.

« Back to merge proposal