Code review comment for lp:~kbielefe/bzr/551391-log-memory-usage

Revision history for this message
John A Meinel (jameinel) wrote :

We should probably have a flag to enable/disable this. "-Ddump_memory" comes to mind. I don't know which should be the default, sort of like core-dumping. I think the default for most people is to have it off, so I would probably go with that. So we could change the error message to mention "use -Dmemory_dump to get a memory dump" (or whatever).

I like the idea, the code seems fine otherwise.

review: Needs Fixing

« Back to merge proposal