Code review comment for lp:~kbielefe/bzr/551391-log-memory-usage

Revision history for this message
Martin Pool (mbp) wrote :

Thanks very much for that.

Beyond John's comments I'd say:

 * probably the dump should go into /tmp (ie use tempfile.mkstemp), so
that it doesn't clutter up or cause trouble in people's working
directory; then print the name

 * if you get an ImportError or other error, please log the exception
so we have a chance of debugging it

 * I would print the filename, not just logging it - or return it, and
let the higher-level code print it

--
Martin

« Back to merge proposal