Code review comment for lp:~kbielefe/bzr/551391-log-memory-usage

Revision history for this message
Martin Pool (mbp) wrote :

This actually causes one correct test failure:

======================================================================
FAIL: bzrlib.tests.test_trace.TestTrace.test_format_memory_error
----------------------------------------------------------------------
_StringException: Text attachment: log
------------
1966.897 Traceback (most recent call last):
 File "/home/pqm/bzr-pqm-workdir/home/+trunk/bzrlib/tests/test_trace.py", line 79, in test_format_memory_error
   raise MemoryError()
MemoryError

------------
Text attachment: traceback
------------
Traceback (most recent call last):
 File "/usr/lib/python2.4/site-packages/testtools/runtest.py", line 128, in _run_user
   return fn(*args)
 File "/usr/lib/python2.4/site-packages/testtools/testcase.py", line 368, in _run_test_method
   testMethod()
 File "/home/pqm/bzr-pqm-workdir/home/+trunk/bzrlib/tests/test_trace.py", line 84, in test_format_memory_error
   "bzr: out of memory\n")
AssertionError: not equal:
a = 'bzr: out of memory\nUse -Dmem_dump to dump memory to a file.\n'
b = 'bzr: out of memory\n'

------------

That's nice because we can check it is actually being printed.

review: Needs Fixing

« Back to merge proposal