Code review comment for lp:~kbielefe/bzr/551391-log-memory-usage

Revision history for this message
Karl Bielefeldt (kbielefe) wrote :

Okay, I fixed that test and added another test for if -Dmem_dump is specified. On the latter, I'm getting the following output, which I'm not sure is a problem or not. Also I'm not sure if the test should assume the meliae module is present.

Output of bzr selftest --verbose test_format_mem_dump:

test_trace.TestTrace.test_format_mem_dump /usr/lib/pymodules/python2.6/dbus/_dbus.py:251: DeprecationWarning: The dbus_bindings module is not public API and will go away soon.

Most uses of dbus_bindings are applications catching the exception
dbus.dbus_bindings.DBusException. You should use dbus.DBusException
instead (this is compatible with all dbus-python versions since 0.40.2).

If you need additional public API, please contact the maintainers via
<email address hidden>.

  import dbus.dbus_bindings as m
/usr/lib/python2.6/dist-packages/meliae/scanner.py:94: UnicodeWarning: Unicode equal comparison failed to convert both arguments to Unicode - interpreting them as being unequal
  recurse_depth=recurse_depth)
   OK 3602ms
----------------------------------------------------------------------
Ran 1 test in 3.684s

OK

« Back to merge proposal