Code review comment for lp:~kbielefe/bzr/551391-log-memory-usage

Revision history for this message
Vincent Ladeuil (vila) wrote :

>>>>> Karl Bielefeldt <email address hidden> writes:

    >> @Karl: I went ahead and created
    >> https://code.edge.launchpad.net/~vila/bzr/551391-log-memory-usage/+merge/38103
    >> so we can land this patch (see there for details).

    > Thanks for that. My time for open source work comes in bursts.
    > For future reference, should I make it a practice to give bzr-core
    > or someone access to my branch, so you wouldn't need to create a
    > new one?

Hmm, not really.

I was reviewing your submission in a local branch, all I had to do was:

bzr push lp:~vila/bzr/`bzr nick`
bzr lp-open
and add your branch as a pre-requisite when proposing mine for merge.

If I had made a controversial change and thought you may agree or not
with it, I would also have 'bzr push' my branch and told you: 'If these
changes suit you, you could:

 bzr pull lp:~vila/bzr/551391-log-memory-usage

From there, you would have continue working on your branch, then 'bzr
push' again and add a comment in the ongoing merge proposal explaining
the new status.

There are a lot of variations around this theme, but in practive we
rarely use shared branches (in the ~bzr namespace).

« Back to merge proposal