Code review comment for lp:~ken-vandine/gwibber/lp_1058672

Revision history for this message
Michael Terry (mterry) wrote :

Makes sense. The if "/login_success" in url bit makes me slightly nervous about false positives. It seems unlikely that /login_success would appear randomly, but... I dunno. /login_success?success=false maybe?

You know facebook's login better than me. If that's a bogus concern, go ahead. Else, approved with that fixed if it is a real concern.

review: Approve

« Back to merge proposal