Merge lp:~kfogel/launchpad/cc-script-update-reference into lp:launchpad

Proposed by Karl Fogel
Status: Merged
Approved by: Barry Warsaw
Approved revision: no longer in the source branch.
Merged at revision: not available
Proposed branch: lp:~kfogel/launchpad/cc-script-update-reference
Merge into: lp:launchpad
Diff against target: None lines
To merge this branch: bzr merge lp:~kfogel/launchpad/cc-script-update-reference
Reviewer Review Type Date Requested Status
Barry Warsaw (community) code Approve
Edwin Grubbs Pending
Review via email: mp+12102@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Karl Fogel (kfogel) wrote :

Update an error message to point to the correct URL, and update a tuple to list Danilo in Cyrillic so he doesn't show up as a non-Canonical developer even when he commits as "danilo {_AT_} babaroga" :-).

This script is not part of Launchpad, and these changes should not affect Launchpad at all.

Revision history for this message
Karl Fogel (kfogel) wrote :

By the way, this commit happens to work around bug #432742, although that's a coincidence.

Revision history for this message
Barry Warsaw (barry) wrote :

I was glad to see this in the script:

# -*- coding: utf-8 -*-

:)

BTW, when/if we can target nothing earlier than Python 2.6, you can add this import statement and get rid of all those ugly u-prefixes on your strings.

from __future__ import unicode_literals

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'utilities/community-contributions.py'
--- utilities/community-contributions.py 2009-09-11 00:22:13 +0000
+++ utilities/community-contributions.py 2009-09-18 20:58:17 +0000
@@ -47,11 +47,11 @@
47 from editmoin import editshortcut47 from editmoin import editshortcut
48except:48except:
49 sys.stderr.write("""ERROR: Unable to import from 'editmoin'. How to solve:49 sys.stderr.write("""ERROR: Unable to import from 'editmoin'. How to solve:
50As of 2009-09-01, you can get editmoin.py from50Get editmoin.py from launchpadlib's "contrib/" directory:
5151
52 https://bazaar.launchpad.net/~kfogel/lp-dev-utils/lp-user-tools/files52 http://bazaar.launchpad.net/~lazr-developers/launchpadlib/trunk/annotate/head%3A/contrib/editmoin.py
5353
54(This is a transitional location; it may move to a more public place.)54(Put it in the same directory as this script and everything should work.)
55""")55""")
56 sys.exit(1)56 sys.exit(1)
5757
@@ -78,6 +78,8 @@
78 u'Dafydd Harries',78 u'Dafydd Harries',
79 u'Daniel Silverstone',79 u'Daniel Silverstone',
80 u'Danilo Šegan',80 u'Danilo Šegan',
81 u'Данило Шеган',
82 u'данило шеган',
81 u'David Allouche',83 u'David Allouche',
82 u'Deryck Hodge',84 u'Deryck Hodge',
83 u'Diogo Matsubara',85 u'Diogo Matsubara',