gary_poster: kfogel: re https://code.edge.launchpad.net/~kfogel/launchpad/google-analytics-everywhere/+merge/22891 , it's fine. I would remove the lines with only ellipses, because I don't think they buy anything, but if you disagree, I'm ok with it as is.
[09:58am] kfogel: gary_poster: that's a good idea; I wasn't sure quite how "..." matching worked and actually meant to test without those lines, then forgot to.
[09:58am] gary_poster: kfogel: it's very greedy, think ``.*``
[09:59am] kfogel: gary_poster: ok
[09:59am] gary_poster: kfogel: fwiw actually, I think ``.+`` is more accurate
[09:59am] kfogel: gary_poster: gotcha
gary_poster: kfogel: re https:/ /code.edge. launchpad. net/~kfogel/ launchpad/ google- analytics- everywhere/ +merge/ 22891 , it's fine. I would remove the lines with only ellipses, because I don't think they buy anything, but if you disagree, I'm ok with it as is.
[09:58am] kfogel: gary_poster: that's a good idea; I wasn't sure quite how "..." matching worked and actually meant to test without those lines, then forgot to.
[09:58am] gary_poster: kfogel: it's very greedy, think ``.*``
[09:59am] kfogel: gary_poster: ok
[09:59am] gary_poster: kfogel: fwiw actually, I think ``.+`` is more accurate
[09:59am] kfogel: gary_poster: gotcha