Code review comment for lp:~kfogel/launchpadlib/426323-apidoc-html-title-attrs

Revision history for this message
Leonard Richardson (leonardr) wrote :

> This looks good as it is, but I wondered on irc whether it's possible to test
> this in the launchpadlib tree. Does launchpadlib already test its wadl? If
> so, then adding a test for this shouldn't be difficult. If it's not, then we
> won't worry about it for this branch.

There are no tests of the stylesheet in launchpadlib, or anywhere for that matter. I don't recommend making any changes in this branch.

You could write a test that runs the stylesheet on the example WADL in wadllib and then parses the result to prove various things about the translation. This could run within launchpadlib, which already depends on wadllib.

Or you could test the real generated HTML in Launchpad. We already test that the HTML is generated, but we don't look in the file.

« Back to merge proposal