Code review comment for lp:~kriomant/do-plugins/transmission

Revision history for this message
Chris Halse Rogers (raof) wrote :

Oh, wow. Sorry for missing this for so long!

This looks good. I've only got two minor niggles, and one larger one. The two minor ones are: you should have copyright headers on the files you've created, and I'd generally use a lot more automatic properties rather than explicit private _foo variables.

The major one is that it bundles a binary copy of Jayrock.Json. We generally try to minimise the binaries we bundle in the source tree; most distributions will not accept packages with binaries bundled like this.

Given the terrible length of time that this has been waiting for a review, I'm happy to make these changes myself if you don't want to. I would like your email address, though, so that I can credit you in the Authors file properly.

review: Needs Fixing

« Back to merge proposal