Code review comment for lp:~kriomant/do-plugins/transmission

On 11 Dec 2011 10:16, "Chris Halse Rogers" <email address hidden> wrote:
>
> Review: Needs Fixing
>
> Oh, wow. Sorry for missing this for so long!

I thought development is completely stalled.

> This looks good. I've only got two minor niggles, and one larger one.
 The two minor ones are: you should have copyright headers on the files
you've created, and I'd generally use a lot more automatic properties
rather than explicit private _foo variables.
>
> The major one is that it bundles a binary copy of Jayrock.Json. We
generally try to minimise the binaries we bundle in the source tree; most
distributions will not accept packages with binaries bundled like this.

How will you solve this? I haven't found JSON library for Mono in standard
Ubuntu distribution. Will you include source code of Jayrock?

> Given the terrible length of time that this has been waiting for a
review, I'm happy to make these changes myself if you don't want to. I
would like your email address, though, so that I can credit you in the
Authors file properly.

It would be good.
My address is "Mikhail Trishchenkov <email address hidden>"

One more question: should I write wiki page?

> --
> https://code.launchpad.net/~kriomant/do-plugins/transmission/+merge/30966
> You are the owner of lp:~kriomant/do-plugins/transmission.