Code review comment for lp:~leonardr/launchpad/no-mutator-named-operations

Revision history for this message
Guilherme Salgado (salgado) wrote :

This looks good, although the diff currently shows the changes from one of my branches that recently landed on devel. As discussed on IRC, this is because you had branched off of db-devel and then merged devel after I landed my changes.

Also, one thing that concerns me is that we're losing test coverage for things that don't exist in the latest version of the api (e.g. transitionToStatus). Is the plan really to test just whatever is supported by the latest version or am I missing something?

review: Approve (code)

« Back to merge proposal