Code review comment for lp:~leonardr/launchpad/optimized-length-2

Revision history for this message
Michael Nelson (michael.nelson) wrote :

r=me for the change pasted via irc:

14:51 < noodles775> leonardr: I don't see a one-liner? It's r11442 that needs to be reviewed right? This: http://bazaar.launchpad.net/~leonardr/launchpad/optimized-length-2/revision/11442
14:59 < leonardr> noodles775, 11442 corrects a typo made to the original one-liner. i was hoping to just give you the code so it wouldn't be so complicated
14:59 < leonardr> i'll just do another merge proposal and get in the queue
15:01 < noodles775> leonardr: I'm happy to review just the one-line that's changed, but currently I can only see it in 11442 along with a few other changes. If the rest is already reviewed, just paste a diff and I can review that, otherwise yes, a new MP is probably easier.
15:04 < leonardr> noodles775: i see the problem. i had to create a new branch with the old changes, so all the old changes show up as one revision
15:04 < leonardr> this code is the only code that hasn't been reviewed yet:
15:04 < leonardr> + if hasattr(resultset, '_select'):
15:04 < leonardr> + resultset._select.limit = Undef
15:04 < leonardr> + resultset._select.offset = Undef
15:05 < noodles775> leonardr: r=me (I assume the second two lines were there previously, just not indented). Thanks!
15:05 < leonardr> noodles, yeah

review: Approve (code)

« Back to merge proposal