Code review comment for lp:~leonardr/launchpad/temporary-integration

Revision history for this message
Māris Fogels (mars) wrote :

Hi Leonard,

This code looks good. r=mars.

I have some comments about the language in the OAuth UI: I prefer the wording of "Give all programs on this computer access..." over the phrase "Permanently integrate". Similarly, I prefer the wording of "I'd like to allow access for a day" over "I'd like to try the integration for a day". "Integration" is a very technical term. In contrast, the statement "I would like to do X for a day" sounds very concrete.

I suggest getting a review of the UI text for this. I ask because I have found that OAuth screens are a particularly important place to have good usability as they deal with security and the user's fragile confidence. Also, a screenshot with the UI text would help whomever does the usability review.

Maris

review: Approve

« Back to merge proposal