Code review comment for lp:~leonardr/launchpad/temporary-integration

Revision history for this message
Guilherme Salgado (salgado) wrote :

Hi Leonard,

Here are a few suggestions that could help improve things a bit. Given that most of them are wording-related, I'd like Matt Revell to review them as he might have other suggestions.

- Where does the "Ubuntu desktop" part come from? I don't think there's
  anything restricting that page only to Ubuntu desktops, so users of other
  distros might feel either left out or compelled to click "No, thanks".

- I think the heading and the first sentence should make it clear that this
  will give any application on that computer full access to their Launchpad
  account. I say that because the heading just talks about integration, which
  might lead people to think it's something else.

  Maybe we could use something similar to what U1 uses: "Confirm Computer
  Access" as the heading and "Would you like to give all applications running
  on <mycomputer> full access (including making changes) to your Launchpad
  account?"

- I agree with Maris that the word of the buttons should be changed to make
  it clear the user is granting the computer full access to their LP
  account. Also, we can probably avoid the repetition in the buttons by doing
  something like this:

    Allow "mycomputer" to Access my Launchpad Account
        [ Permanently ]
        [ For One Hour ]
        [ For One Day ]
        [ For One Week ]

    Do Not Allow "mycomputer" to Access my Launchpad Account

- Buttons should be Headling Case
  (https://dev.launchpad.net/UserInterfaceWording)

review: Needs Fixing (ui*)

« Back to merge proposal