Code review comment for lp:~leonardr/launchpad/temporary-integration

Revision history for this message
Leonard Richardson (leonardr) wrote :

The *screenshot* looks unstyled because the easiest way for me to take a screenshot was to write the HTML file to disk during a test run and view it locally. The page is a normal Launchpad page and when viewed as part of a running Launchpad instance it will be styled.

I don't understand "in your template you fill the "buttons" slot and layout the buttons as you want". Currently I have this code:

<div metal:fill-slot="buttons" />

As I understand it, this invokes some kind of macro that takes my Actions object and automagically lays out the buttons, one per column.

Are you suggesting something like this?

<div metal fill-slot="buttons">

  Allow "mycomputer" to Access my Launchpad Account

 <div class="indented" id="do-integrate">
  <input type="button" name="Permanently" />
  <input type="button" name="One hour" />
  <input type="button" name="One day" />
  <input type="button" name="One week" />
 </div>

 <!--Note: no "indented" div here-->
  <input type="button" name="Don't integrate" />
</div>

That is, I'm trying to get this effect:

  Allow "mycomputer" to Access my Launchpad Account
        [ Permanently ]
        [ For One Hour ]
        [ For One Day ]
        [ For One Week ]

    Do Not Allow "mycomputer" to Access my Launchpad Account

But I have no idea how to do this, either on the level of the CSS styling or the level of the PT templates. I would prefer not to lay out all four of the "yes, i want to integrate" buttons manually--that's why I suggested having two Actions objects.

Can you help me?

« Back to merge proposal