Code review comment for lp:~leonardr/launchpad/temporary-integration

Revision history for this message
Curtis Hovey (sinzui) wrote :

On Wed, 2010-10-20 at 15:13 +0000, Leonard Richardson wrote:
> <div metal fill-slot="buttons">
>
> Allow "mycomputer" to Access my Launchpad Account
>
> <div class="indented" id="do-integrate">
> <input type="button" name="Permanently" />
> <input type="button" name="One hour" />
> <input type="button" name="One day" />
> <input type="button" name="One week" />
> </div>
>
> <!--Note: no "indented" div here-->
> <input type="button" name="Don't integrate" />
> </div>

The question-index.pt template renders its button manually:

            <div class="actions" metal:fill-slot="buttons">
              <div>
                <input tal:replace="structure view/answer_action/render" />
                <input tal:replace="structure view/selfanswer_action/render" />
                <input tal:replace="structure view/requestinfo_action/render" />
                <input tal:replace="structure view/giveinfo_action/render" />
                <input tal:replace="structure view/reopen_action/render" />
                <input tal:replace="structure view/comment_action/render" />
              </div>

I think you want to add some structure around the buttons to group them.
You will need <br/> or wrap each is a <div> to create the vertical list.

« Back to merge proposal