Launchpad itself

Code review comment for lp:~leonardr/launchpad/test-representation-cache

Revision history for this message

Brad Crittenden (bac) wrote on 2010-06-01:

Hi Leonard,

Thanks for this branch -- it looks very promising. A 4x increase would be great.

It looks like you haven't pushed your changes to the download cache up yet so lazr.restful 0.9.27 isn't available. Be sure to do that.

You define but don't use 'json_type' in webservice/cache.txt.

The __all__ in memcache/client.py should be on multiple lines.

It looks like there are some valid complaints from 'make lint'. Please run it and clean up the ones that are real.

review: Approve (code)