Code review comment for lp:~leonardr/launchpad/toggle-representation-cache

Revision history for this message
Aaron Bentley (abentley) wrote :

As discussed in IRC
- Please catch storm.exceptions.ClassInfoError rather than Exception
- If possible, narrow the scope of the related try/except block.
- Please be more specific in applying defaults, so that cached values that evaluate to False are handled correctly.

review: Approve

« Back to merge proposal