1
=== modified file 'setup.py'
2
--- setup.py	2010-06-16 19:48:04 +0000
3
+++ setup.py	2010-06-21 15:38:24 +0000
4
@@ -60,7 +60,7 @@
5
60
    license='LGPL v3',
60
    license='LGPL v3',
6
61
    install_requires=[
61
    install_requires=[
7
62
        'httplib2',
62
        'httplib2',
9
63
        'lazr.restfulclient>=0.9.18',
63
        'lazr.restfulclient>=0.9.19',
10
64
        'lazr.uri',
64
        'lazr.uri',
11
65
        'oauth',
65
        'oauth',
12
66
        'setuptools',
66
        'setuptools',
13
67
67
14
=== modified file 'src/launchpadlib/NEWS.txt'
15
--- src/launchpadlib/NEWS.txt	2010-06-16 19:48:04 +0000
16
+++ src/launchpadlib/NEWS.txt	2010-06-21 15:38:24 +0000
17
@@ -2,6 +2,12 @@
18
2
NEWS for launchpadlib
2
NEWS for launchpadlib
19
3
=====================
3
=====================
20
4
4
21
5
1.6.2 (2010-06-21)
22
6
==================
23
7
24
8
- Extended the optimization from version 1.6.1 to apply to Launchpad's
25
9
  top-level collection of people.
26
10
27
5
1.6.1 (2010-06-16)
11
1.6.1 (2010-06-16)
28
6
==================
12
==================
29
7
13
30
8
14
31
=== modified file 'src/launchpadlib/__init__.py'
32
--- src/launchpadlib/__init__.py	2010-06-16 19:48:04 +0000
33
+++ src/launchpadlib/__init__.py	2010-06-21 15:38:24 +0000
34
@@ -14,4 +14,4 @@
35
14
# You should have received a copy of the GNU Lesser General Public License
14
# You should have received a copy of the GNU Lesser General Public License
36
15
# along with launchpadlib. If not, see <http://www.gnu.org/licenses/>.
15
# along with launchpadlib. If not, see <http://www.gnu.org/licenses/>.
37
16
16
39
17
__version__ = '1.6.1'
17
__version__ = '1.6.2'
40
18
18
41
=== modified file 'src/launchpadlib/docs/toplevel.txt'
42
--- src/launchpadlib/docs/toplevel.txt	2010-06-16 19:48:04 +0000
43
+++ src/launchpadlib/docs/toplevel.txt	2010-06-21 15:38:24 +0000
44
@@ -49,23 +49,63 @@
45
49
    ubuntu
49
    ubuntu
46
50
50
47
51
The person collection does lookups by a person's Launchpad
51
The person collection does lookups by a person's Launchpad
52
52
name. Looking up a person from the top-level collection of people
52
name.
49
53
*does* trigger an HTTP request, since there's no other way to tell
50
54
whether a given person should be represented by a 'person' object or a
51
55
'team' object.
53
56
53
54
57
    >>> person = launchpad.people['salgado']
54
    >>> person = launchpad.people['salgado']
55
58
    send: 'GET /.../~salgado ...'
56
59
    ...
57
60
    >>> print person.name
55
    >>> print person.name
58
56
    send: 'GET /.../~salgado ...'
59
57
    ...
60
61
    salgado
58
    salgado
61
62
59
62
63
    >>> team = launchpad.people['rosetta-admins']
60
    >>> team = launchpad.people['rosetta-admins']
63
61
    >>> print team.name
64
64
    send: 'GET /1.0/~rosetta-admins ...'
62
    send: 'GET /1.0/~rosetta-admins ...'
65
65
    ...
63
    ...
66
66
    >>> print team.name
67
67
    rosetta-admins
64
    rosetta-admins
68
68
65
69
66
How does launchpadlib know that 'salgado' is a person and
70
67
'rosetta-admins' is a team?
71
68
72
69
    >>> print person.resource_type_link
73
70
    http://.../1.0/#person
74
71
    >>> 'default_membership_period' in person.lp_attributes
75
72
    False
76
73
77
74
    >>> print team.resource_type_link
78
75
    http://.../1.0/#team
79
76
    >>> 'default_membership_period' in team.lp_attributes
80
77
    True
81
78
82
79
The truth is that it doesn't know, not before making that HTTP
83
80
request. Until the HTTP request is made, launchpadlib assumes
84
81
everything in launchpad.people[] is a team (since a team has strictly
85
82
more capabilities than a person).
86
83
87
84
    >>> person2 = launchpad.people['salgado']
88
85
    >>> 'default_membership_period' in person2.lp_attributes
89
86
    True
90
87
91
88
But accessing any attribute of an object--even trying to see what kind
92
89
of object 'salgado' is--will trigger the HTTP request that will
93
90
determine that 'salgado' is actually a person.
94
91
95
92
    >>> print person2.resource_type_link
96
93
    send: 'GET /.../~salgado ...'
97
94
    ...
98
95
    http://.../1.0/#person
99
96
100
97
    >>> 'default_membership_period' in person2.lp_attributes
101
98
    False
102
99
103
100
Accessing an attribute of an object that might be a team will trigger
104
101
the HTTP request, and then cause an error if the object turns out not
105
102
to be a team.
106
103
107
104
    >>> person3 = launchpad.people['salgado']
108
105
    >>> person3.default_membership_period
109
106
    Traceback (most recent call last):
110
107
    AttributeError: 'Entry' object has no attribute 'default_membership_period'
111
108
112
69
Cleanup.
109
Cleanup.
113
70
110
114
71
    >>> httplib2.debuglevel = None
111
    >>> httplib2.debuglevel = None
115
72
112
116
=== modified file 'src/launchpadlib/launchpad.py'
117
--- src/launchpadlib/launchpad.py	2010-06-16 19:48:04 +0000
118
+++ src/launchpadlib/launchpad.py	2010-06-21 15:38:24 +0000
119
@@ -50,7 +50,7 @@
120
50
    # The only way to determine whether a string corresponds to a
50
    # The only way to determine whether a string corresponds to a
121
51
    # person or a team object is to ask the server, so looking up an
51
    # person or a team object is to ask the server, so looking up an
122
52
    # entry from the PersonSet always requires making an HTTP request.
52
    # entry from the PersonSet always requires making an HTTP request.
124
53
    collection_of = None
53
    collection_of = 'team'
125
54
54
126
55
55
127
56
class BugSet(CollectionWithKeyBasedLookup):
56
class BugSet(CollectionWithKeyBasedLookup):
Status:	Merged
Approved by:	Gary Poster on 2010-06-21
Approved revision:	91
Merged at revision:	90
Proposed branch:	lp:~leonardr/launchpadlib/shim-users
Merge into:	lp:launchpadlib
Diff against target:	127 lines (+56/-10) 5 files modified setup.py (+1/-1) src/launchpadlib/NEWS.txt (+6/-0) src/launchpadlib/__init__.py (+1/-1) src/launchpadlib/docs/toplevel.txt (+47/-7) src/launchpadlib/launchpad.py (+1/-1)
To merge this branch:	bzr merge lp:~leonardr/launchpadlib/shim-users
Related bugs:	Link a bug report
Reviewer	Review Type	Date Requested	Status
Gary Poster		2010-06-21	Approve on 2010-06-21
Review via email: mp+28067@code.launchpad.net