Code review comment for lp:~leonardr/launchpadlib/trusted-workflow-tests-2

Revision history for this message
Leonard Richardson (leonardr) wrote :

> As you explained to me on IRC, this is because you're using the python
> naming standard instead of the LP one. Fair enough, but the two methods
> below use the LP one. Care to rename them?

I've renamed getSingleCharInput and pressEnterToExit.

> And here's a review of the two remaining files, which had conflicts when
> I first reviewed your branch. Just one question, in fact.
>
> > === modified file 'src/launchpadlib/credentials.py'
> > --- src/launchpadlib/credentials.py 2009-10-30 14:48:21 +0000
> > +++ src/launchpadlib/credentials.py 2009-10-30 19:55:30 +0000
> > @@ -289,16 +291,20 @@
> >
> > def __init__(self, web_root, consumer_name, request_token,
> > allow_access_levels=[], max_failed_attempts=3):
> > - self.web_root = web_root
> > + self.web_root = uris.lookup_web_root(web_root)
>
> What's the reason for this change?

I think I explained this on IRC too, but for the record: lookup_web_root lets you pass in "staging" as the site root instead of "https://staging.launchpad.net/".

« Back to merge proposal