Code review comment for lp:~leonardr/launchpadlib/use-shorthand-uris-in-all-tests

Revision history for this message
Leonard Richardson (leonardr) wrote :

We had some untested code paths to do with shorthand URIs like 'edge'. This is because the Launchpad instance used for tests didn't have a shorthand URI, so we used the long-form URI everywhere. This masked several places where shorthand URIs, when passed in, were not being dereferenced.

This branch changes all our tests that use 'http://api.launchpad.dev:8085/beta/' or 'http://launchpad.dev:8085/' to use the shorthand string 'dev_test' instead. This caused several tests to fail due to a lack of dereferencing code. The most important one is a bug I just introduced into Launchpad.login_with, which was breaking typical usage of popular launchpadlib scripts.

« Back to merge proposal