Code review comment for lp:~leonardr/lazr.restful/exported-subclass
Revision history for this message
| Leonard Richardson (leonardr) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Ignore the title; it has nothing to do with what this branch is actually about. This branch contains fixes for miscellaneous bugs I found while integrating multiversion lazr.restful into Launchpad.
The "list(versions)" code fixes a failure that happens when you run lazr.restful under Python 2.5 (as Launchpad does). The incoming list of versions is a tuple object, and tuple objects don't implement index() until 2.6.
The change to metazcml.py fixes a failure that happens when you publish both an interface and a subclass of that interface. The superclass and subclass both publish the same Method object as a named operation, which was causing a ZCML conflict. I changed the ZCML discriminator to include the interface object, making it possible for two classes to publish the same method. I added a subclass of ICookbook to the example web service to test this.