lazr.restful

Merge lp:~leonardr/lazr.restful/fix-remove-recipe into lp:lazr.restful

  1. fix-remove-recipe
  2. Merge into trunk
Proposed by Leonard Richardson
Status: Rejected
Rejected by: Leonard Richardson
Proposed branch: lp:~leonardr/lazr.restful/fix-remove-recipe
Merge into: lp:lazr.restful
Diff against target: 45 lines (+8/-4)
3 files modified
src/lazr/restful/NEWS.txt (+6/-0)
src/lazr/restful/example/base/configure.zcml (+1/-3)
src/lazr/restful/version.txt (+1/-1)
To merge this branch: bzr merge lp:~leonardr/lazr.restful/fix-remove-recipe
Reviewer Review Type Date Requested Status
Leonard Richardson (community) Disapprove
Review via email: mp+24423@code.launchpad.net

Description of the change

This very simple branch adds 'removeRecipe' to the list of "require" attributes for Cookbook, so that the Zope security proxy allows that method to be called. Without this change, lazr.restfulclient can't DELETE a recipe.

Why is there no test? Because I can't figure out why the existing tests pass. The same code runs whether we test DELETE in lazr.restful or lazr.restfulclient. I don't see why the Zope security proxy shouldn't be running in the lazr.restful tests, but clearly it hasn't been.

Is this mystery worth resolving right now?

To post a comment you must log in.
Revision history for this message
Leonard Richardson (leonardr) wrote :

This seems not to have been necessary--presumably it wasn't a real problem or was resolved some other way.

review: Disapprove

Unmerged revisions

128. By Leonard Richardson

Initial representation.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/lazr/restful/NEWS.txt'
--- src/lazr/restful/NEWS.txt 2010-04-14 15:04:35 +0000
+++ src/lazr/restful/NEWS.txt 2010-04-29 13:39:23 +0000
@@ -2,6 +2,12 @@
2NEWS for lazr.restful2NEWS for lazr.restful
3=====================3=====================
44
50.9.26 (2010-04-29)
6===================
7
8Corrected a bit of ZCML that was causing lazr.restfulclient test
9failures.
10
50.9.25 (2010-04-14)110.9.25 (2010-04-14)
6===================12===================
713
814
=== modified file 'src/lazr/restful/example/base/configure.zcml'
--- src/lazr/restful/example/base/configure.zcml 2009-09-01 14:37:41 +0000
+++ src/lazr/restful/example/base/configure.zcml 2010-04-29 13:39:23 +0000
@@ -6,8 +6,6 @@
6 <webservice:register module="lazr.restful.example.base.interfaces" />6 <webservice:register module="lazr.restful.example.base.interfaces" />
7 <grok:grok package="lazr.restful.example.base" />7 <grok:grok package="lazr.restful.example.base" />
88
9 <!--Security configuration-->
10
11 <permission id="lazr.restful.example.base.View" title="Viewing something" />9 <permission id="lazr.restful.example.base.View" title="Viewing something" />
12 <permission id="lazr.restful.example.base.ViewPrivate"10 <permission id="lazr.restful.example.base.ViewPrivate"
13 title="Viewing private information" />11 title="Viewing private information" />
@@ -20,7 +18,7 @@
20 <require attributes="name copyright_date cover cuisine description18 <require attributes="name copyright_date cover cuisine description
21 recipes find_recipe_for find_recipes last_printing19 recipes find_recipe_for find_recipes last_printing
22 make_more_interesting price replace_cover20 make_more_interesting price replace_cover
23 revision_number get"21 revision_number get removeRecipe"
24 set_attributes="name copyright_date cover cuisine description22 set_attributes="name copyright_date cover cuisine description
25 last_printing price revision_number"23 last_printing price revision_number"
26 permission="zope.Public" />24 permission="zope.Public" />
2725
=== modified file 'src/lazr/restful/version.txt'
--- src/lazr/restful/version.txt 2010-04-13 21:07:08 +0000
+++ src/lazr/restful/version.txt 2010-04-29 13:39:23 +0000
@@ -1,1 +1,1 @@
10.9.2510.9.26

Subscribers

People subscribed via source and target branches