There's one thing that I think is missing though, tests and
code for when there is an existing artefact from the previous
version. It appears to me as if this code will not use that
as the left-hand parent of the created revision.
Plus two smaller things:
119 + db.branch.repository.fetch
looks wrong to me, and I would like a trace.note() or similar
that explains how the user can get at the newly imported
revision. Yes, it's the tag named upstream-$VERSION with the
version they provided, but a note will mean that people don't
have to infer that.
Hi,
This looks good to me, thanks.
There's one thing that I think is missing though, tests and
code for when there is an existing artefact from the previous
version. It appears to me as if this code will not use that
as the left-hand parent of the created revision.
Plus two smaller things:
119 + db.branch. repository. fetch
looks wrong to me, and I would like a trace.note() or similar
that explains how the user can get at the newly imported
revision. Yes, it's the tag named upstream-$VERSION with the
version they provided, but a note will mean that people don't
have to infer that.
Thanks,
James