Code review comment for lp:~lifeless/bzr/bug-398668

On Tue, 2009-08-18 at 13:42 +0000, John A Meinel wrote:
> Review: Approve
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Robert Collins wrote:
> > Robert Collins has proposed merging lp:~lifeless/bzr/bug-398668 into lp:bzr.
> >
> > The diff is likely still a problem - here is a manual diff.
>
> Sorry, I meant to include:
> review: approve
>
> Provided there is agreement about WT5 vs WT6.

2a is format 6, and thats a supported format. Assuming that you're
right, we need to actually downgrade 2a in 1.16/1.17/1.18 as well -
definitely out of scope for this patch - and while changing the default
will increase the number of 2a users out there, we have from now until
the release to decide on this.

There is one outstanding log test I need to change as well, but I'll
land that change asynchronously - I don't want to let this [somewhat
fragile branch] bitrot at all.

Thanks for the review.

-Rob