Code review comment for lp:~lifeless/bzr/bug-398668

Robert Collins wrote:
> On Tue, 2009-08-18 at 13:42 +0000, John A Meinel wrote:
>> Review: Approve
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Robert Collins wrote:
>>> Robert Collins has proposed merging lp:~lifeless/bzr/bug-398668 into lp:bzr.
>>>
>>> The diff is likely still a problem - here is a manual diff.
>> Sorry, I meant to include:
>> review: approve
>>
>> Provided there is agreement about WT5 vs WT6.
>
> 2a is format 6, and thats a supported format. Assuming that you're
> right, we need to actually downgrade 2a in 1.16/1.17/1.18 as well -

I'd prefer to keep the format exactly as it is now and stay with WT6.
I'm happy to make filtered views an experimental-only feature for 2.0,
say so loudly in the doc and hide the view command if appropriate. But I
don't want to remove the ability to store the filtered view metadata in
the default format.

Ian C.