Code review comment for lp:~lifeless/bzr/commands

Revision history for this message
Andrew Bennetts (spiv) wrote :

52 + This is called by __init__ to make the Command be able to be run
53 + by just calling run(), as it could be before cleanups were added.

This part of the docstring is a bit unclear. People using the Command API shouldn't need to know about the history of the API to be able to use it.

Perhaps it should say something like this instead:

    This is called by __init__ to make it possible to call cmd.run()
    directly.

I'm still a bit uncomfortable with being so tricky, but it does seem like the best compromise that preserves the APIs we like (that subclasses can override run; callers can invoke run directly; cleanups added during run will be executed).

review: Approve

« Back to merge proposal