Code review comment for lp:~lifeless/bzr/commit

Revision history for this message
John A Meinel (jameinel) wrote :

You don't seem to have a test case for the 'failing' side. Where the user is prompted but they request to *not* commit.

That code path seems to:
  return ""

Whereas the other code paths when the template file doesn't exist, or _run_editor fails:
  return None

Otherwise it seems ok.

review: Needs Fixing

« Back to merge proposal