Code review comment for lp:~lifeless/bzr/subunit

2009/12/6 Robert Collins <email address hidden>:
> I'm proposing this branch to get feedback; its not necessarily ripe, though I'd be happy to land it as-is (there aren't any must-do items remaining for it).

Well done.

> === modified file 'NEWS'
> --- NEWS        2009-12-04 22:13:52 +0000
> +++ NEWS        2009-12-06 03:05:32 +0000
> @@ -237,6 +237,10 @@
>  Testing
>  *******
>
> +* ``bzrlib.tests.TestCase`` now subclasses ``testtools.testcase.TestCase``.
> +  This permits features in testtools such as getUniqueInteger and
> +  getUniqueString to be used. (Robert Collins)
> +
>  * -Dhpssvfs will now trigger on ``RemoteBzrDir._ensure_real``, providing
>   more debugging of VFS access triggers. (Robert Collins)

You really need to explicitly mention that testtools is now a
requirement for running the Bazaar test suite, and which version, and
preferably also the URL. It seems like this should also update the
install instructions and maybe setup.py?

Also worth checking that you get a sane message if it's missing.

Since testtools will be changing I'd think about putting in a version
number check after the import.

More later maybe.

--
Martin <http://launchpad.net/~mbp/>