Code review comment for lp:~lifeless/bzr/subunit

8 +* New helper osutils.StreamWriter which encodes unicode objects but
9 + passes str objects straight through. This is used for selftest but
10 + may be useful for diff and other operations that generate mixed output.
11 + (Robert Collins)
12 +

Please let's not have two things called StreamWriter that behave differently. needsfixing. Something like UnicodeOrBytesToBytesWriter.

+ log = u"".join(self.getDetails()['log'].iter_text())

Agree with Matt, this is ugly to repeat. Couldn't we have a convenience function for it?